E53E fix: eventlet compatibility by tito · Pull Request #3132 · docker/docker-py · GitHub
[go: up one dir, main page]
Skip to content

fix: eventlet compatibility #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix: eventlet compatibility #3132

merged 1 commit into from
Jun 1, 2023

Conversation

tito
Copy link
Contributor
@tito tito commented May 16, 2023

The implementation done in #2865 is breaking usage of docker-py library within eventlet. As per the Python select.poll documentation (https://docs.python.org/3/library/select.html#select.poll) and eventlet select removal advice (eventlet/eventlet#608 (comment)), it is preferable to use an implementation based on the availability of the poll() method that trying to check if the platform is win32.

Fixes #3131

@tito
Check if poll attribute exists on select module instead of win32 plat…
8a4c55f 
…form check

The implementation done in docker#2865 is breaking usage of docker-py library within eventlet.
As per the Python `select.poll` documentation (https://docs.python.org/3/library/select.html#select.poll) and eventlet select removal advice (eventlet/eventlet#608 (comment)), it is preferable to use an implementation based on the availability of the `poll()` method that trying to check if the platform is `win32`.

Fixes docker#3131

Signed-off-by: Mathieu Virbel <mat@meltingrocks.com>
@tito tito changed the title Check if poll attribute exists on select module - eventlet compatibility fix: eventlet compatibility May 16, 2023
@milas milas added the kind/bug label May 23, 2023
@milas milas self-assigned this May 23, 2023
@milas milas merged commit 78439eb into docker:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiordache aiordache Awaiting requested review from aiordache

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

1 more reviewer

@milas milas milas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@milas milas

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use docker with eventlet since #2865
2 participants
@tito @milas
0