E52A [master] fix some minor nits by thaJeztah · Pull Request #714 · docker/docker-ce-packaging · GitHub
[go: up one dir, main page]
Skip to content

[master] fix some minor nits #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[master] fix some minor nits #714

wants to merge 2 commits into from
+7 −7

Conversation

@thaJeztah
Copy link
Member
@thaJeztah thaJeztah commented Jun 30, 2022

static: create hashes for all files, not just linux

Also switching to alpine, instead of debian:jessy, which is EOL

Makefile: set initial branch name

Set an initial branch name so that git doe 8000 s not create additional noise
about the default not being configured. Using "master" for now, which
was the previous default; we can probably safely change it to "main",
but leaving that for a future exercise.

thaJeztah added 2 commits June 30, 2022 17:20
@thaJeztah
static: create hashes for all files, not just linux
2ff15db 
Also switching to alpine, instead of debian:jessy, which is EOL

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Makefile: set initial branch name
3164a49 
Set an initial branch name so that git does not create additional noise
about the default not being configured. Using "master" for now, which
was the previous default; we can probably safely change it to "main",
but leaving that for a future exercise.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author
thaJeztah commented Jun 30, 2022

Ah, hm.... looks like we're running on older versions of git;

+ make REF=master raspbian-bullseye
Init https://github.com/docker/cli.git�
git init --initial-branch=master src/github.com/docker/cli
error: unknown option `initial-branch=master'
usage: git init [-q | --quiet] [--bare] [--template=<template-directory>] [--shared[=<permissions>]] [<directory>]

    --template <template-directory>
                          directory from which templates will be used
    --bare                create a bare repository
    --shared[=<permissions>]
                          specify that the git repository is to be shared amongst several users
    -q, --quiet           be quiet
    --separate-git-dir <gitdir>
                          separate git dir from working tree

Makefile:25: recipe for target 'src/github.com/docker/cli' failed
make: *** [src/github.com/docker/cli] Error 129
script returned exit code 2

@thaJeztah thaJeztah marked this pull request as draft July 1, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thaJeztah
0