8000 Pass compatibility flag to v2 by mat007 · Pull Request #21 · docker/compose-switch · GitHub
[go: up one dir, main page]
Skip to content

Pass compatibility flag to v2#21

Merged
ulyssessouza merged 1 commit intodocker:masterfrom
mat007:compatibility-flag
Nov 29, 2021
Merged

Pass compatibility flag to v2#21
ulyssessouza merged 1 commit intodocker:masterfrom
mat007:compatibility-flag

Conversation

@mat007
Copy link
Member
@mat007 mat007 commented Nov 26, 2021

Fixes #15

@mat007 mat007 requested a review from ulyssessouza November 26, 2021 09:21
@mat007 mat007 force-pushed the compatibility-flag branch from 0b0ed4b to 5e4b33c Compare November 26, 2021 09:24
@mat007 mat007 force-pushed the compatibility-flag branch from 5e4b33c to 071dcf7 Compare November 27, 2021 09:23
@ulyssessouza ulyssessouza merged commit abf9d0f into docker:master Nov 29, 2021
@ndeloof
Copy link
Contributor
ndeloof commented Dec 2, 2021

Too late, but a strong 👎 on this.
Many users (including me) use docker-compose as a command and expect a full V2 target. This should not just be considered a "legacy compatibility" mode

@mat007
Copy link
Member Author
mat007 commented Dec 2, 2021

Ah sorry @ndeloof I should have pinged you when creating this PR.

Can you elaborate a bit? If you’re expecting V2, is there any reason you can’t directly invoke docker compose?

@ndeloof
Copy link
Contributor
ndeloof commented Dec 2, 2021

As of 2.0.1 compose v2 is distributed on a few Linux distros (typically: arch) as drop-in replacement for docker-compose
I also have a bunch of scripts here relying on docker-compose but still wanted to use V2.

IMHO compose v2 should not be restricted to "cli plugin" and docker space compose, this is just the new compose.

@mat007
Copy link
Member Author
mat007 commented Dec 3, 2021

But isn’t docker-compose usable as a standalone binary now?
Discussing with @ulyssessouza he mentioned that Arch Linux are actually using the plugin directly as a binary just like that?

@ndeloof
Copy link
Contributor
ndeloof commented Dec 3, 2021

Yes indeed, our released binary can be used both as a CLI plugin or standalone binary as drop in replacement for docker-compose. That's my point: using the latter I expect I can run compose V2 I installed, I'm not in a hidden transition phase

This was referenced Dec 7, 2021
Closed
Closed
This was referenced Dec 13, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need to pass --compatibility-flag

3 participants

@mat007 @ndeloof @ulyssessouza
0