8000 linux installation sctipt by ndeloof · Pull Request #1 · docker/compose-switch · GitHub
[go: up one dir, main page]

Skip to content

linux installation sctipt#1

Merged
ndeloof merged 1 commit intodocker:masterfrom
ndeloof:master
Sep 8, 2021
Merged

linux installation sctipt#1
ndeloof merged 1 commit intodocker:masterfrom
ndeloof:master

Conversation

@ndeloof
Copy link
Contributor
@ndeloof ndeloof commented Sep 8, 2021

Added installation script for Linuxes.
Based on @ulyssessouza's previous script, with minor changes:

@ndeloof
Copy link
Contributor Author
ndeloof commented Sep 8, 2021

tested within an alpine container with fake /usr/bin/docker and /usr/bin/docker-compose:

/work # ./install_on_linux.sh 
Downloading compose v1->v2 switch into /tmp/tmp.CdEldo...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     42      0 --:--:-- --:--:-- --:--:--    42
Switching Docker Compose binary
Compose v1->v2 installed
Docker Compose V2 enabled
To switch back to compose v1, you can run:
$ docker-compose disable-v2

Copy link
Member
@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some nits 😀

Comment on lines +5 to +4
# FIXME Use final URLs
COMPOSE_SWITCH_URL="https://github.com/docker/compose-switch/releases/download/$COMPOSE_SWITCH_VERSION/docker-compose"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not the final URL now?

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Member
@lorenrh lorenrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndeloof ndeloof merged commit 13c9990 into docker:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0