Document CLI support for per interface sysctls #4994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8248665 to
e91f6e2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4994 +/- ##
==========================================
+ Coverage 61.09% 61.33% +0.24%
==========================================
Files 298 295 -3
Lines 20675 20701 +26
==========================================
+ Hits 12631 12697 +66
+ Misses 7147 7101 -46
- Partials 897 903 +6 |
e91f6e2 to
5474acf
Compare
dvdksn
reviewed
Apr 8, 2024
5474acf to
774ed6a
Compare
The test didn't do anything useful... - Despite its name it used newCreateCommand() instead of newConnectCommand() with create flags/options instead of connect. - There was no fake networkCreateFunc(), so the result of the 'connect' wasn't checked. - The fake networkConnectFunc() was never called, so didn't spot the problem. Signed-off-by: Rob Murray <rob.murray@docker.com>
Support for connecting more than one network using the container run command was added in v25.0 for API > 1.44 - describe that in the docs. Signed-off-by: Rob Murray <rob.murray@docker.com>
f4cef3e to
9f7d811
Compare
|
@thaJeztah does this LGTY? |
akerouanton
approved these changes
May 17, 2024
Signed-off-by: Rob Murray <rob.murray@docker.com>
Signed-off-by: Rob Murray <rob.murray@docker.com>
Signed-off-by: Rob Murray <rob.murray@docker.com>
Signed-off-by: Rob Murray <rob.murray@docker.com>
9f7d811 to
d5d94e4
Compare
|
Updated to reflect a last-minute change of heart on the sysctl naming ( |
akerouanton
approved these changes
May 29, 2024
dvdksn
approved these changes
May 29, 2024
rumpl
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
com.docker.network.endpoint.sysctls, to support per-interface sysctls.The extended
--networksyntax is needed, but wasn't documented.The quoting needed to set more than one sysctl using
docker [create|run] --network driver-optordocker network connect --driver-optisn't obvious - so, added tests and examples to the docs.- How I did it
TestNetworkConnectWithFlags- because it didn't do anything, and is needed to test the new option.--networksyntax.- How to verify it
New tests added.
- Description for the changelog