8000 Bash completion: add '--replicas-max-per-node' by thaJeztah · Pull Request #1686 · docker/cli · GitHub
[go: up one dir, main page]
Skip to content

Bash completion: add '--replicas-max-per-node' #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2019
Merged

Bash completion: add '--replicas-max-per-node' #1686

merged 1 commit into from
Feb 22, 2019

Conversation

thaJeztah
Copy link
Member

whoops; realised we didn't add this one (follow up to #1612)

@thaJeztah
Bash completion: add '--replicas-max-per-node'
cd7d2df 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from albers as a code owner February 22, 2019 10:21
@thaJeztah
Copy link
Member Author

@olljanat @albers @vdemeester ptal 🤗

@codecov-io
Copy link

Codecov Report

Merging #1686 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1686   +/-   ##
=======================================
  Coverage   56.07%   56.07%           
=======================================
  Files         306      306           
  Lines       20997    20997           
=======================================
  Hits        11774    11774           
  Misses       8373     8373           
  Partials      850      850

@olljanat
Copy link
Contributor
olljanat commented Feb 22, 2019 •
edited
Loading

Looks good 👍

albers
albers approved these changes Feb 22, 2019
View reviewed changes
Copy link
Collaborator
@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiborvass tiborvass merged commit 3ddb313 into docker:master Feb 22, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Feb 22, 2019
@thaJeztah t 78CC haJeztah deleted the max_replicas_completion branch February 22, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborvass tiborvass tiborvass approved these changes

@albers albers albers approved these changes

Assignees
No one assigned
Labels
area/completion status/2-code-review
Projects
None yet
Milestone
19.03.0
Development

Successfully merging this pull request may close these issues.
6 participants
@thaJeztah @codecov-io @olljanat @tiborvass @albers @GordonTheTurtle
0