10000 Unwrap completion exception for legacy async handling by ibauersachs · Pull Request #387 · dnsjava/dnsjava · GitHub
[go: up one dir, main page]

Skip to content

Unwrap completion exception for legacy async handling #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025

Conversation

ibauersachs
Copy link
Member

Closes #383

Closes #383

Co-authored-by: bhaveshthakker <bhaveshthakker111@gmail.com>
@ibauersachs ibauersachs added this to the v3.6.4 milestone Jun 28, 2025
Copy link
codecov bot commented Jun 28, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.63%. Comparing base (60e75e5) to head (9998b1c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/xbill/DNS/Resolver.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #387      +/-   ##
============================================
+ Coverage     66.21%   66.63%   +0.41%     
- Complexity     3032     3043      +11     
============================================
  Files           198      198              
  Lines         13596    13598       +2     
  Branches       2116     2117       +1     
============================================
+ Hits           9003     9061      +58     
+ Misses         4032     3967      -65     
- Partials        561      570       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ibauersachs ibauersachs merged commit cd0bbdf into master Jun 28, 2025
25 of 27 checks passed
@ibauersachs ibauersachs deleted the bugfix/unwrap-completionex branch June 28, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async ResolverListener receives wrapped CompletionException on timeouts, inconsistent with sync send()
1 participant
0