Fixed confusing parameter name in CNAMERecord #354

chkal · 2024-11-29T10:00:06Z

The CNAMERecord class has a constructor parameter for the CNAME target which is called alias at the moment. This is quite confusing, because:

The API docs states that this parameter is "The name to which the CNAME alias points". So it is NOT the alias itself (which is the name of the record), but the target to which the record points.
There is a deprecated method CNAMERecord#getAlias() which does NOT return the value supplied with the alias constructor parameter, but returns the name of the record instead.

I think it would be help to rename this parameter to target. That is also consistent with the name used in NSRecord and PTRRecord.

ibauersachs · 2024-11-29T11:05:46Z

Agree. Thanks for the cleanup!

Fixed confusing parameter name in CNAMERecord

ff09959

ibauersachs merged commit d445fe8 into dnsjava:master Nov 29, 2024
14 checks passed

ibauersachs added this to the v3.6.3 milestone Nov 29, 2024

chkal deleted the fix-cname-parameter-name branch November 29, 2024 11:16

Provide feedback