8000 Issue 295, addresses bug with TSIG verification of large responses. by frankarinnet · Pull Request #298 · dnsjava/dnsjava · GitHub
[go: up one dir, main page]
Skip to content

Issue 295, addresses bug with TSIG verification of large responses. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Issue 295, addresses bug with TSIG verification of large responses. #298

wants to merge 3 commits into from

Conversation

frankarinnet
Copy link
Contributor

This pull request is in reference to: #295

As requested, this PR targets the 3.5.x branch. It obseletes #296.

From the old PR:

There are still some TODOs, however, because I need some guidance on how to deal with thread safety in the TSIG.

So, don't merge this without commenting.

and

I've created: https://github.com/frankarinnet/axfr

Which might be helpful for testing this. It was the simplest program I could write to demonstrate this bug for manual testing.

But you will still need to:

    set up a DNS server
    with TSIG
    that allows full zone transfers (AXFR)
    configured with a few different-sized zones

For zone sizes, I've been using:

    a small zone (with 8 lines)
    a medium zone (with 8k lines)
    a large zone (with 160k lines)

This was referenced Oct 24, 2023
Closed
8000
Closed
ibauersachs added a commit that referenced this pull request Oct 29, 2023
@ibauersachs @frankarinnet @nguichon
Fix handling of multi-message TSIG responses
36a0c7f 
Closes #295
Closes #297
Closes #298
Closes #299

Co-authored-by: Frank Hill <frank@arin.net>
Co-authored-by: Nick Guichon <nickg@arin.net>
@ibauersachs ibauersachs mentioned this pull request Oct 29, 2023
Merged
@ibauersachs ibauersachs mentioned this pull request Nov 4, 2023
Merged
ibauersachs added a commit that referenced this pull request Nov 4, 2023
@ibauersachs @frankarinnet @nguichon
Fix handling of multi-message TSIG responses (#303)
b575ca8 
* Fix handling of multi-message TSIG responses

Closes #295
Closes #297
Closes #298
Closes #299
Closes #301

Co-authored-by: Frank Hill <frank@arin.net>
Co-authored-by: Nick Guichon <nickg@arin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankarinnet @nguichon
0