Fix Name constructor failing with max length relative name and root origin #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rigin The Name constructor failed when passing a max-length (253 chars) relative name and Name.root as origin, while this name is technically allowed. The failure was caused by the Name constructor having the local "absolute" variable wrongly set to false in this case. This change fixes this by updating this flag when the origin is present. Previous to this fix the workaround was to pass a null origin and manually append the final dot (root) to the string: in this case the constructor would work (as demonstrated by the "ctor_max_length_abs" test. With this change I've also added a few tests for these edge-cases.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
============================================
- Coverage 64.25% 64.18% -0.07%
+ Complexity 2771 2767 -4
============================================
Files 178 178
Lines 12539 12540 +1
Branches 1912 1912
============================================
- Hits 8057 8049 -8
- Misses 3994 3998 +4
- Partials 488 493 +5
☔ View full report in Codecov by Sentry. |
|
There are two failing jobs:
|
|
Thanks! The failed test is a bit brittle, I need to rework that. And the code coverage is probably lower because of the other failed test. I'll have a deeper look at the changes, there was already an edge case about this somewhere. |
|
Thanks again. Sorry for showing this as closed, I've cherry-picked the commit into the release/3.5.x branch. |
|
No worries, thank you :) |
|
Thank you for adding this fix, it is very helpful. Looking forward to seeing it in the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Name constructor failed when passing a max-length (253 chars) relative name and Name.root as origin, while this name is technically allowed.
The failure was caused by the Name constructor having the local "absolute" variable wrongly set to false in this case. This change fixes this by updating this flag when the origin is present.
Previous to this fix the workaround was to pass a null origin and manually append the final dot (root) to the string: in this case the constructor would work (as demonstrated by the "ctor_max_length_abs" test.
With this change I've also added a few tests for these edge-cases.