8000 Allow SVCB ServiceMode records without params by adam-stoler · Pull Request #244 · dnsjava/dnsjava · GitHub
[go: up one dir, main page]
Skip to content

Allow SVCB ServiceMode records without params #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2022
Merged

Allow SVCB ServiceMode records without params #244

merged 1 commit into from
Jan 18, 2022

Conversation

adam-stoler
Copy link
Contributor
@adam-stoler adam-stoler commented Jan 18, 2022 •
edited
Loading

Fixes #243
Remove incorrect check that required at least one param to be specified for ServiceMode records
Add unit tests to verify that ServiceMode records without any params are allowed and can be properly converted between text and wire formats

Remove incorrect check that required at least one param to be specifi…
41ddd7e 
…ed for ServiceMode records

Add unit tests to verify that ServiceMode records without any params are allowed and can be properly converted between text and wire formats
@codecov-commenter
Copy link

Codecov Report

Merging #244 (41ddd7e) into master (4eff203) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #244   +/-   ##
=========================================
  Coverage     57.26%   57.26%           
+ Complexity     2088     2083    -5     
=========================================
  Files           163      163           
  Lines         10907    10905    -2     
  Branches       1573     1572    -1     
=========================================
- Hits           6246     6245    -1     
+ Misses         4235     4234    -1     
  Partials        426      426
Impacted Files Coverage Δ
src/main/java/org/xbill/DNS/SVCBBase.java 91.88% <ø> (-0.05%) ⬇️
src/main/java/org/xbill/DNS/DohResolver.java 49.82% <0.00%> (-0.69%) ⬇️
src/main/java/org/xbill/DNS/DNSSEC.java 56.33% <0.00%> (-0.21%) ⬇️
src/main/java/org/xbill/DNS/NioTcpClient.java 67.94% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eff203...41ddd7e. Read the comment docs.

@adam-stoler adam-stoler changed the title Allow SVCB ServiceMode records with params Allow SVCB ServiceMode records without params Jan 18, 2022
@ibauersachs ibauersachs merged commit 4dea758 into dnsjava:master Jan 18, 2022
@ibauersachs ibauersachs added this to the v3.5 milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.

dnsjava refuses to create a HTTPS record from a String if at least one parameter is not provided
3 participants
@adam-stoler @codecov-commenter @ibauersachs
0