8000 TCPClient: Fix recv timeout to properly use nanoseconds (#218) by nguydavi · Pull Request #219 · dnsjava/dnsjava · GitHub
[go: up one dir, main page]
Skip to content

TCPClient: Fix recv timeout to properly use nanoseconds (#218) #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TCPClient: Fix recv timeout to properly use nanoseconds (#218) #219

wants to merge 1 commit into from

Conversation

nguydavi
Copy link

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #219 (24a2933) into master (700856f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
- Coverage     57.21%   57.17%   -0.04%     
+ Complexity     2089     2088       -1     
============================================
  Files           163      163              
  Lines         10908    10908              
  Branches       1573     1573              
============================================
- Hits           6241     6237       -4     
- Misses         4250     4252       +2     
- Partials        417      419       +2
Impacted Files Coverage Δ
src/main/java/org/xbill/DNS/TCPClient.java 0.00% <0.00%> (ø)
src/main/java/org/xbill/DNS/NioTcpClient.java 65.38% <0.00%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700856f...24a2933. Read the comment docs.

@ibauersachs ibauersachs linked an issue Sep 23, 2021 that may be closed by this pull request
TCPClient incorrect receive timeout #218
Closed
@ibauersachs
Copy link
Member

Thanks!
Actually, instead of just replace millis with nanos, the class should store the timeout value instead of endTime to avoid the numeric overflow mentioned in the Javadoc of nanoTime(). Would you mind refactoring TCPClient like this?
Also, 3.5 (current master) will take a while before there's a release. You might want to target the 3.4.x branch instead.

@ibauersachs ibauersachs added this to the v3.5 milestone Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.

TCPClient incorrect receive timeout
3 participants
@nguydavi @codecov-commenter @ibauersachs
0