[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Chinese translation #164

Merged
merged 16 commits into from
Feb 10, 2023
Merged

Improved Chinese translation #164

merged 16 commits into from
Feb 10, 2023

Conversation

Wenveo
Copy link
@Wenveo Wenveo commented Jan 27, 2023

Improve the translation of Chinese

* Replace the Chinese colon and parentheses with the English ones

* Semantic improvement ...
Copy link
@UlyssesWu UlyssesWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢参与翻译,以上问题可以再讨论。

@Wenveo Wenveo requested a review from UlyssesWu January 28, 2023 17:30
Copy link
@UlyssesWu UlyssesWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦了,还剩几个小问题

@Wenveo Wenveo changed the title Improved chinese translation Improved Chinese translation Jan 29, 2023
@Wenveo Wenveo requested a review from UlyssesWu January 30, 2023 14:48
Copy link
@UlyssesWu UlyssesWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

Thanks for your contribution @noisrev !
request merge @ElektroKill

</data>
<data name="DecompilerSettings_DecompilationOrder" xml:space="preserve">
<value>反编译顺序</value>
</data>
<data name="DecompilerSettings_DecompileAnonMethods" xml:space="preserve">
<value>反编译匿名方法/lambda方法</value>
<value>反编译匿名方法和 lambda 方法</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET官方文档均为 lambda 表达式

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我会更改的

Copy link
@UlyssesWu UlyssesWu Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太同意,官方文档也有两种表达;而且,应当尊重原文的两种表述
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/operators/lambda-expressions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那这里不应该是 Lambda 表达式和匿名函数吗

确实,我可能误解了他的意思(我以为他要去掉“匿名方法”)。Lambda后面如果要接一个词,更合理的应该是“表达式”。可能是因为原文只是lambdas(而不是lambda expressions),所以原来的翻译才会写成这样。至于“匿名方法”,由于原文就是methods,所以至少不能算错,但改成“函数”也不错。

Decompile anonymous methods/lambdas

@@ -184,13 +184,13 @@
<value>最大字符串长度</value>
</data>
<data name="DecompilerSettings_MemberAddPrivateModifier" xml:space="preserve">
<value>添加private标识符到类成员</value>
<value>为类成员添加 private 关键字</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类(class) => 类型(type)

</data>
<data name="DecompilerSettings_ShowTokensRvasOffsets" xml:space="preserve">
<value>显示标记,RVA和文件偏移</value>
<value>显示标记,相对虚拟地址和文件偏移</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“标记”是个通用词,含义不明确,另外这里应该使用顿号分隔:
显示元数据标记、相对虚拟地址和文件偏移

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

</data>
<data name="DecompilerSettings_TypeAddInternalModifier" xml:space="preserve">
<value>添加internal标识符到类</value>
<value>为类添加 internal 关键字</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类(class) => 类型(type)

</data>
<data name="DisassembleBAMLCommand" xml:space="preserve">
<value>反汇编BAML</value>
<value>反汇编 BAML</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

与前述一样,要么统一成“反汇编”,要么统一成“反编译”

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是很同意,反汇编和反编译BAML的意义不同

</data>
<data name="Error_AttachedEvent" xml:space="preserve">
<value>附加事件 '{0}'。</value>
</data>
<data name="Error_IComponentConnectorConnectCannotBeParsed" xml:space="preserve">
<value> '{0}' IComponentConnector.Connect 方法,但无法解析。</value>
<value>目标类 '{0}' 存在 IComponentConnector.Connect 方法,但无法解析。</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类(class) => 类型(type)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

反对,原文就是Class

Class '{0}' has IComponentConnector.Connect method, but cannot be parsed.

</data>
<data name="Error_IStyleConnectorConnectCannotBeParsed" xml:space="preserve">
<value> '{0}' IStyleConnector.Connect 方法,但无法解析。</value>
<value>目标类 '{0}' 存在 IStyleConnector.Connect 方法,但无法解析。</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类(class) => 类型(type)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

反对,原文就是Class

</data>
<data name="Error_UnknownConnectionId" xml:space="preserve">
<value>未知连接 ID{0}</value>
<value>未知的连接 ID: {0}</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"的“字多余

@@ -133,7 +133,7 @@
<value>调试中</value>
</data>
<data name="AskDeleteAllBreakpoints" xml:space="preserve">
<value>要删除所有的断点吗?</value>
<value>是否要删除所有的断点?</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否删除所有断点?

</data>
<data name="Error_CantEvalWhenUnhandledExceptionHasOccurred" xml:space="preserve">
<value>当未捕捉异常发生时无法计算</value>
<value>当未捕的捉异常发生时无法求值</value>
Copy link
@CreateAndInject CreateAndInject Feb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当引发未捕获的异常时无法求值

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</data>
<data name="InvalidChar" xml:space="preserve">
<value>字符必须括在单引号 (')</value>
</data>
<data name="InvalidDateTime" xml:space="preserve">
<value>值必须为DateTime</value>
<value>目标值必须为 DateTime</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接翻译成“无效的 DateTime“就行了吧?这里表达的是数据格式错误,而不是使用了其他类型。
比如数据为:"2023.2.6",如果提示为“目标值必须为 DateTime”,会让用户一头雾水,他会觉得本来就已经是日期数据了,怎么还说不是呢?如果提示“无效的 DateTime“,用户就会觉得可能是分隔符错误,从而尝试使用"2023-2-6"或"2023/2/6"。其他的地方类似。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接翻译成“无效的 DateTime“就行了吧?

这个我倒没注意到,确实这样比较好理解

Copy link
Author
@Wenveo Wenveo Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接翻译成“无效的 DateTime“就行了吧?

虽然这样看起来简单直白,但是描述的不够清晰。
还有很多相似的内容,总不能全都翻译成 无效的 xxx 吧。

譬如 InvalidBooleanInvalidCharInvalidString1 ......

其次,目标 这两个字可有可无,如有觉得不恰当我可以将它们删除掉

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑一个输入框只允许输入数字,当按下'a'键时,可能引发InvalidChar,此时如果提示:目标值必须为 Char,就是说'a'不是Char类型,但显然'a'就是Char,只是说在当前输入框是无效的

Copy link
Author
@Wenveo Wenveo Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实上方就有这个 InvalidChar: 字符必须括在单引号 (')

在考虑到你说的这些之后,我认为就是 无效的 DateTime,请检查分隔符或格式是否拼写正确

在此基础上加多一条信息,这样既不会太单调,也能起到一个提示的效果。
如果没问题的话,其它地方我也会更改为类似的这种

Copy link
@CreateAndInject CreateAndInject Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没必要添加额外信息

  1. 你并不能确定格式错误是什么原因,我说"2023.2.6"只是一个示例,如果是"year2035"这样,那就是完完全全的无效数据,并不是增加分隔符就能解决的
  2. 额外信息往往存在于Message属性中,不需要根据异常类型来添加额外信息

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那改回原本的翻译如何

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看你吧,我觉得能直译就没必要再绕弯了

@@ -208,6 +208,6 @@
<value>被使用</value>
</data>
<data name="UsesTreeNode" xml:space="preserve">
<value>使用</value>
<value>使用于</value>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“使用”指的是正在分析的方法里用到了哪些其他方法,“使用于”听起来更像是“被使用”。我觉得之前的翻译没问题。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好吧,改的时候一下子没想明白(雾)

Copy link
@UlyssesWu UlyssesWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@ElektroKill ElektroKill merged commit 1508910 into dnSpyEx:master Feb 10, 2023
@ElektroKill
Copy link
Member

Thanks a lot for this contribution :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants