10000 Fix re-order command for custom order field models by yuekui · Pull Request #257 · django-ordered-model/django-ordered-model · GitHub
[go: up one dir, main page]
Skip to content

Fix re-order command for custom order field models #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 12, 2022
Merged

Fix re-order command for custom order field models #257

merged 4 commits into from
Jan 12, 2022

Conversation

yuekui
Copy link
Contributor
@yuekui yuekui commented Jan 12, 2022 •
edited
Loading

Fix AttributeError error raised in reorder command when re-ordering models with custom order field.

@shuckc
Copy link
Member
shuckc commented Jan 12, 2022

Thanks - do you want to include the summary of the change in /CHANGES.md and I'm happy to merge

@yuekui
Copy link
Contributor Author
yuekui commented Jan 12, 2022

Thanks - do you want to include the summary of the change in /CHANGES.md and I'm happy to merge

Sure, just updated, please review. Thanks!

@shuckc shuckc merged commit 5d11d7f into django-ordered-model:master Jan 12, 2022
@shuckc
Copy link
Member
shuckc commented Jan 12, 2022

Merged and pushed to pypy in release 3.5 https://pypi.org/project/django-ordered-model/3.5/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuckc shuckc shuckc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuekui @shuckc
0