8000 Remove pipchecker and associated tests by browniebroke · Pull Request #1906 · django-extensions/django-extensions · GitHub
[go: up one dir, main page]
Skip to content

Remove pipchecker and associated tests #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove pipchecker and associated tests #1906

merged 2 commits into from
Jan 17, 2025

Conversation

browniebroke
Copy link
Contributor
@browniebroke browniebroke commented Jan 7, 2025 •
edited
Loading

@browniebroke browniebroke mentioned this pull request Jan 7, 2025
Closed
@browniebroke
Copy link
Contributor Author

Do you think we could merge that one as is @trbs? There are still a few other tests failing but they seem unrelated to pipchecker so I was thinking it might be better to fix them separately

@trbs
Copy link
Member
trbs commented Jan 17, 2025 •
edited
Loading

Do you think we could merge that one as is @trbs? There are still a few other tests failing but they seem unrelated to pipchecker so I was thinking it might be better to fix them separately

Yeah I will merge it as-is.

Could you also remove line #95 in docs/command_extensions.rst ?
(I can do it separately as well but nice to have it in your PR 👍 )
Then we got everything I think :-)

@browniebroke
Copy link
Contributor Author

Could you also remove line #95 in docs/command_extensions.rst ?

Good catch, done!

@trbs trbs merged commit 9454353 into django-extensions:main Jan 17, 2025
5 of 24 checks passed
@trbs
Copy link
Member
trbs commented Jan 17, 2025

Thanks !

@browniebroke browniebroke deleted the remove/pipchecker-command branch January 17, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@browniebroke @trbs
0