8000 Django 4.0 by webs86 · Pull Request #1698 · django-extensions/django-extensions · GitHub
[go: up one dir, main page]
Skip to content

Django 4.0 #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 27, 2022
Merged

Django 4.0 #1698

merged 12 commits into from
May 27, 2022

Conversation

webs86
Copy link
Contributor
@webs86 webs86 commented Jan 7, 2022

Added support for django 4.0

ulgens
ulgens reviewed Jan 7, 2022
View reviewed changes
@webs86
Copy link
Contributor Author
webs86 commented Jan 7, 2022

Hi @ulgens I have reviewed all. If you like run tests and if all ok approve pull request.

@ulgens
Copy link
Contributor
ulgens commented Jan 7, 2022 •
edited
Loading

@webs86 Python 3.6, Django 3.0 and Django 3.1 are dead. If we remove those, the test matrix will get simpler and I don't think there will be the need for pytest-dj4 section.

@jayvdb jayvdb mentioned this pull request Feb 3, 2022
Open
@TheBitShepherd
Copy link

@webs86 - Do we know what the timeline for merging this is?

@webs86
Copy link
Contributor Author
webs86 commented Mar 17, 2022 •
edited
Loading

@webs86 - Do we know what the timeline for merging this is?

I haven't modified supported versions because there is also compatibility with Django 2.2.

If @ulgens or somebody confirm to drop support to Python 3.6, Django 3.0 and Django 3.1 I think I can complete the change by early next week

@webs86
Copy link
Contributor Author
webs86 commented Mar 17, 2022

I have applied suggested drop support so is possible to merge

@TheBitShepherd
Copy link

@CryptoGodfatherVA2 - Would you be the correct person to approve this?

@webs86
Copy link
Contributor Author
webs86 commented Apr 3, 2022

I think now this is ready to be merged

@webs86
Copy link
Contributor Author
webs86 commented Apr 13, 2022

What is timeline to merge this pull request?

@ulgens
Copy link
Contributor
ulgens commented Apr 13, 2022

@trbs 👋🏻

@browniebroke
Copy link
Contributor

Very nice! What's missing to get this merged? Anything the community can do to help with this?

@browniebroke browniebroke mentioned this pull request May 1, 2022
Closed
@Jihad
Copy link
Jihad commented May 4, 2022

@dakrauth @trbs 👋🏼 can we help in any way?

@mazulo
Copy link
mazulo commented May 20, 2022

Awesome work, folks! Are we missing anything to merge this?

@mazulo
Copy link
mazulo commented May 23, 2022

cc @camilonova @dakrauth @empty @trbs

@camilonova camilonova merged commit 5190ad2 into django-extensions:main May 27, 2022
@camilonova
Copy link
Member

Thank you!

@gador gador mentioned this pull request May 29, 2022
Merged
@GitRon
Copy link
GitRon commented May 31, 2022

Hi there! I am experiencing some issues with django 4 - I guess they'd be fixed with these changes. Any idea when the new version will be released?

Error fetching command 'dumpscript': cannot import name 'smart_text' from 'django.utils.encoding' (C:\Users\ronny.virtualenvs\backend-6qNpIncx\lib\site-packages\django\utils\encoding.py)
Command 'dumpscript' skipped
Error fetching command 'show_template_tags': cannot import name 'smart_text' from 'django.utils.encoding' (C:\Users\ronny.virtualenvs\backend-6qNpIncx\lib\site-packages\django\utils\encoding.py)
Command 'show_template_tags' skipped

trbs pushed a commit that referenced this pull request Jul 8, 2022
remove note about Django<4.0 since #1698 got merged
8dc4fdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulgens ulgens ulgens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@webs86 @ulgens @TheBitShepherd @browniebroke @Jihad @mazulo @camilonova @GitRon
0