Flag for graph_models to color code relations based on on_delete. (#1604) #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good addition. And you provided tests, so I suspect this will be an easy commit once the maintainers get a chance to take a look! |
|
Thanks! I think it's pretty easy to work out, but are the meanings of the colours documented anywhere? |
|
@mscheper It's not explicitly documented anywhere 🧐 It would be good to have it in the rst doc, though |
Yeah, I ended up working it out and putting it in my project's docs. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a new flag (
--color-code-deletions) for the graph_models command. It adds custom colors for 'ForeignKey's and 'OneToOneField's edges, based on their on_delete setting. That allows a quick visual understanding of the effects of a model's deletion, as proposed on issue #1604.This is my first contribution on this project, so, if anything can/should be improved, let me know!
Closes #1604.