8000 Add --rankdir to graph_models by ppolewicz · Pull Request #1580 · django-extensions/django-extensions · GitHub
[go: up one dir, main page]
Skip to content

Add --rankdir to graph_models #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2021
Merged

Add --rankdir to graph_models #1580

merged 3 commits into from
Jul 13, 2021

Conversation

ppolewicz
Copy link
Contributor

Closes #1567

@coveralls
Copy link
coveralls commented Sep 5, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling 4e71923 on ppolewicz:rankdir into bf412a5 on django-extensions:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-71.2%) to 0.0% when pulling 9bad9fd on ppolewicz:rankdir into 5c35428 on django-extensions:master.

@trbs
Copy link
Member
trbs commented Sep 25, 2020

Thanks ! Could you please update the PR to fix the conflict ?

Also could you please add a test in the test suite and documentation in docs/ for the new feature ?

@ppolewicz
Copy link
Contributor Author

Sorry for the delay - it was a conference season. Conflict is now fixed.

I thought about adding a test but noticed that this is a really, really simple parameter passing and there are two or three parameters like that already, which are not tested, so I'd have to add some machinery for this kind of stuff and tbh I don't think it's really worth it. Do you think it is?

I missed the docs, thanks for pointing it out, will update.

@JackAtOmenApps
Copy link
Contributor

Looks like there are still several test fails in CI. Maybe needs some additional rework before it can be merged.

@agoncharov-reef
Copy link
Contributor

Docs updated, branch rebased on latest main branch.
I think previous CI failure was unrelated to changes in this PR. I reran some of the failing tests locally and they passed.
Could anyone please trigger testing workflows?

@ppolewicz
Copy link
Contributor Author

@OmenApps can you please approve the CI?

@JackAtOmenApps
Copy link
Contributor

@ppolewicz While I have contributed to the package in the past and have a great deal of interest in django-extensions, I have no official authority. I believe @trbs is the only one authorized to complete approvals.

@trbs
Copy link
Member
trbs commented Jul 13, 2021

Yeah it's a new safety feature after switching from Travis to Github Actions...

@trbs trbs merged commit 6cdf84e into django-extensions:main Jul 13, 2021
@trbs
Copy link
Member
trbs commented Jul 13, 2021

Thanks !

@ppolewicz ppolewicz deleted the rankdir branch July 13, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rankdir support for graph_models
5 participants
@ppolewicz @coveralls @trbs @JackAtOmenApps @agoncharov-reef
0