8000 Bug: GraphModels, style per app only applied using certain theme · Issue #1926 · django-extensions/django-extensions · GitHub
[go: up one dir, main page]
Skip to content

Bug: GraphModels, style per app only applied using certain theme #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
p-fruck opened this issue Apr 14, 2025 · 4 comments
Closed

Bug: GraphModels, style per app only applied using certain theme #1926

p-fruck opened this issue Apr 14, 2025 · 4 comments

Comments

@p-fruck
Copy link
p-fruck commented Apr 14, 2025

I discovered by chance that the graph_models command now has an additional option to support per-app styling (#1848). I was stoked to try it out but had a hard time getting it to work. It seems like the custom style is only applied when adding the -t django2018style flag, the default django2018 does not work - Which means that the docs added in #1925 also did not work for me.

I am not sure if it is intended to support custom styles only on a single theme or if support for other themes is planned in the future, but I think it should be pointed out in the docs at least.

I am excited to see this feature in action, it really helps increasing the readability of our UML diagram :)
@p-fruck
Copy link
Author
p-fruck commented Apr 14, 2025

Also I wanted to point out that if a custom file is specified (e.g. using --app-style does-not-exist.json) the file is silently omitted which could be irritating to some users

@trbs
Copy link
Member
trbs commented Apr 15, 2025

@ahmad88me can you help here and share some insights ?

ahmad88me added a commit to ahmad88me/django-extensions that referenced this issue Apr 15, 2025
@ahmad88me
add support to --app-style for graph_models django-extensions#1926
64cb4b7
@ahmad88me ahmad88me mentioned this issue Apr 15, 2025
Merged
@ahmad88me
Copy link
Contributor

@trbs Done 😉
@p-fruck You are right. Pull request is created here: #1929

@p-fruck
Copy link
Author
p-fruck commented Apr 15, 2025 via email

trbs pushed a commit that referenced this issue Apr 22, 2025
@ahmad88me
graph_models --app-style to support django2018 theme (#1929)
6d3dca5 
* add app-style option

* remove django_extensions/__init__.py

* add __init__.py again

* lint fix

* add support to --app-style for graph_models #1926

* raise exception of the provided app style for graph_models does not exist
@trbs trbs closed this as completed May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trbs @ahmad88me @p-fruck
0