8000 Version 4.4.1 changes the look of DRF browsable API · Issue #1922 · django-commons/django-debug-toolbar · GitHub
[go: up one dir, main page]
Skip to content

Version 4.4.1 changes the look of DRF browsable API #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeroenbrouwer opened this issue May 27, 2024 · 8 comments · Fixed by #1923
Closed

Version 4.4.1 changes the look of DRF browsable API #1922

jeroenbrouwer opened this issue May 27, 2024 · 8 comments · Fixed by #1923

Comments

@jeroenbrouwer
Copy link

After upgrading to version 4.4.1 the browsable API suddenly becomes partly dark:
image

Whereas on version 4.3 it looks like this:
image
@matthiask
Copy link
Member

I don't have a project ready with DRF; can you tell which CSS rule does this? Thanks in advance!

@matthiask
Copy link
Member

Maybe those lines are the problem:
https://github.com/jazzband/django-debug-toolbar/blob/97b49d178b3c2d30cc92ff4fd4f0ecbdcb8bc137/debug_toolbar/static/debug_toolbar/css/toolbar.css#L14
https://github.com/jazzband/django-debug-toolbar/blob/97b49d178b3c2d30cc92ff4fd4f0ecbdcb8bc137/debug_toolbar/static/debug_toolbar/css/toolbar.css#L38

matthiask added a commit to matthiask/django-debug-toolbar that referenced this issue May 27, 2024
@matthiask
Avoid setting color-scheme on :root, we're only a guest on pages
4cf61f6 
Fixes django-commons#1922.
@matthiask matthiask mentioned this issue May 27, 2024
Merged
2 tasks
@matthiask
Copy link
Member

@jeroenbrouwer It would be great if you could test #1923 !

@jeroenbrouwer
Copy link
Author

Disabling this CSS property in Chrome dev-tools fixes it:
image

@matthiask
Copy link
Member

Thanks. Yes, I thought that this was the case. TBH I was unsure if this property was even needed when merging the PR.

matthiask added a commit that referenced this issue May 27, 2024
@matthiask
Avoid setting color-scheme on :root, we're only a guest on pages (#1923)
4808add 
Fixes #1922.
@jeroenbrouwer
Copy link
Author

@jeroenbrouwer It would be great if you could test #1923 !

Just tested #1923 and it fixes the issue!

@matthiask
Copy link
Member

Thanks for confirming!

@jeroenbrouwer
Copy link
Author

Thanks for confirming!

No worries, thanks for the very fast fixing of this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid setting color-scheme on :root, we're only a guest on pages matthiask/django-debug-toolbar
2 participants
@matthiask @jeroenbrouwer
0