8000 Update test matrix to include Django 5 by protoroto · Pull Request #662 · django-cms/djangocms-text-ckeditor · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Update test matrix to include Django 5 #662

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Update test matrix to include Django 5 #662

merged 1 commit into from
Nov 30, 2023

Conversation

protoroto
Copy link
Contributor

Update test matrix to include Django 5

Refs: #661

@codecov Codecov
Copy link
codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05f9b27) 81.79% compared to head (531b0c2) 81.79%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   81.79%   81.79%           
=======================================
  Files          20       20           
  Lines         912      912           
  Branches      122      122           
=======================================
  Hits          746      746           
  Misses        138      138           
  Partials       28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksweb
Copy link
Member

Django 5 doesn't support python 3.7

And it's worth dropping 3.7, though I'm happy to go that in a separate PR if you want to just exclude it from Django 5 in this one.

https://endoflife.date/python

@protoroto protoroto force-pushed the feature/issue-661-add-django-5-support branch from 418289f to 531b0c2 Compare November 28, 2023 19:41
@protoroto
Copy link
Contributor Author

Django 5 doesn't support python 3.7

And it's worth dropping 3.7, though I'm happy to go that in a separate PR if you want to just exclude it from Django 5 in this one.

https://endoflife.date/python

@marksweb Yep, I missed that in the exclude: anyway, Django 5.0 tests fails for something quite strange, maybe related to djangocms-picture...? I'll mark this pr as draft until I can wrap my head around this

@protoroto protoroto marked this pull request as draft November 28, 2023 19:44
@protoroto
Copy link
Contributor Author

@marksweb I'm trying to understand this: I can replicate this issue also on djangocms-picture, if I add Django 5 and CMS 4.1 to the test matrix I get the same error, django.db.utils.OperationalError: no such table: django_site.
I can only find very old issues on django-cms about this, and I don't know where to start to fix this: it looks like something is trying to access sites framework before the actual db is setup or migrated.

@fsbraun
Copy link
Member
fsbraun commented Nov 29, 2023 •
edited
Loading

@protoroto I think it's an issue with Django CMS' LazyChoiceField. The parent's class implementation has changed in Django 5.0 and LazyChoiceField in the current implementation seems not so lazy after all.

As a result djangocms-picture tries to access the DB before the Django initialisation is finished.

I will look at it later today.

@fsbraun fsbraun mentioned this pull request Nov 29, 2023
Merged
4 tasks
@protoroto protoroto marked this pull request as ready for review November 30, 2023 07:57
@protoroto
Copy link
Contributor Author

@fsbraun I've seen the fix merged on djangoCMS, tryed locally and now Django5 tests are passing... but I'm not able to trigger the CI here to re-run failed tasks, so whenever you can, let's see if they're passing here too :)

@fsbraun
Copy link
Member
fsbraun commented Nov 30, 2023

@protoroto Looks good! 👍

@fsbraun fsbraun merged commit aeae78d into django-cms:master Nov 30, 2023
@fsbraun fsbraun mentioned this pull request Nov 30, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@protoroto @marksweb @fsbraun
0