10000 fix(release): Remove requirements of 'django-treebeard==4.5.0' (#51) by DmytroLitvinov · Pull Request #52 · django-cms/djangocms-attributes-field · GitHub
[go: up one dir, main page]

Skip to content

fix(release): Remove requirements of 'django-treebeard==4.5.0' (#51) #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(release): Remove requirements of 'django-treebeard==4.5.0' (#51) #52

wants to merge 1 commit into from

Conversation

DmytroLitvinov
Copy link
@DmytroLitvinov DmytroLitvinov commented Apr 7, 2022

Description

Closes #51

v4.5.0 has breaking changes for djangocms. More details: django-cms/django-cms#6988
Fix version requirements of django-treebeard. More details provided at issue #51.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

marksweb
marksweb previously approved these changes Apr 7, 2022
Copy link
Member
@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you @DmytroLitvinov

@marksweb marksweb dismissed their stale review April 7, 2022 07:22

Ok so even with 4.5.1, the tests are showing the same error seen by users in 4.5.

@DmytroLitvinov
Copy link
Author

Added the same checking of version for requirements in tests.

@fsbraun
Copy link
Member
fsbraun commented May 19, 2023

Has been solved by #53

@fsbraun fsbraun closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

django-treebeard strict pin version
3 participants
0