Feature/sorted option for Attributes Widget #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 90.25% 89.67% -0.59%
==========================================
Files 3 3
Lines 154 155 +1
Branches 29 30 +1
==========================================
Hits 139 139
Misses 10 10
- Partials 5 6 +1
Continue to review full report at Codecov.
|
marksweb
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional parameter to the
AttributesWidgetwhich is a widely used to supply attributes to html tags. HTML attributes do not have an order which is why theAttributesWidgetdisplays them alphabetically by key.With this PR
AttributesWidget(sorted=False)keeps the attributes in order of the dictionary used (which since python 3.6 is preserved). This allows the reuse of the widget for other key value pairs, such as, e.g., choices.If no
sortedparameter is given theAttributesWidgetretains alphabetical order to stay backwards compatible.Sorry, this PR might have overlapping commits with #47