8000 fix: Add `default_auto_field` to cms/apps.py by fsbraun · Pull Request #8254 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Add default_auto_field to cms/apps.py #8254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vinitkumar merged 2 commits into from
Jun 16, 2025
Merged

fix: Add default_auto_field to cms/apps.py #8254

vinitkumar merged 2 commits into from
Jun 16, 2025

Conversation

@fsbraun
Copy link
Member
@fsbraun fsbraun commented Jun 12, 2025 •
edited
Loading

Description

Adds the default_auto_field property to cms.apps and menus.apps`.

Fixes #8253 - no more migrations created when project DEFAULT_AUTO_FIELD is not set to AutoField.

Related resources

Checklist

  • I have opened this pull request against main
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Enhancements:

  • Add default_auto_field attribute to CMSConfig and MenusConfig to prevent Django warnings about missing default auto fields

@sourcery-ai
Copy link
Contributor
sourcery-ai bot commented Jun 12, 2025 •
edited
Loading

Reviewer's Guide

Explicitly set the default_auto_field attribute on the CMS AppConfig to 'django.db.models.AutoField', ensuring model primary keys use the intended field type by default.

Updated Class Diagram for CMSConfig

classDiagram
    class CMSConfig {
        +name: str
        +verbose_name: str
        +default_auto_field: str
        +ready()
    }
Loading

File-Level Changes

Change Details Files
Define default_auto_field on CMSConfig
  • Add default_auto_field='django.db.models.AutoField' to CMSConfig
 cms/apps.py

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the rev 8000 iewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
github-actions bot commented Jun 12, 2025

👋 Hi there!

Please remember to MERGE COMMIT pull requests from main!

Do not SQUASH commits to preserve history for the changelog.

@github-actions
Copy link
github-actions bot commented Jun 12, 2025

👋 Hi there!

Please remember to MERGE COMMIT pull requests from main!

Do not SQUASH commits to preserve history for the changelog.

marksweb
marksweb approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member
@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah should be that easy.

@fsbraun fsbraun mentioned this pull request Jun 12, 2025
Closed
1 task
@vinitkumar vinitkumar merged commit 4a12dd3 into release/5.0.x Jun 16, 2025
68 checks passed
fsbraun added a commit that referenced this pull request Jun 18, 2025
@fsbraun
fix: Add default_auto_field to cms/apps.py (#8254)
14425d2 
* fix: Add `default_auto_field` to cms/apps.py

* Add default_autofield to `menus.apss`
fsbraun added a commit that referenced this pull request Jun 18, 2025
@fsbraun
fix: Add default_auto_field to cms/apps.py (#8254)
82b3ed4 
* fix: Add `default_auto_field` to cms/apps.py

* Add default_autofield to `menus.apss`
@fsbraun fsbraun deleted the chore/autofield branch September 30, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marksweb marksweb marksweb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fsbraun @marksweb @vinitkumar
0