8000 fix: Page settings raised an exception when `USE_I18N = False` by fsbraun · Pull Request #8236 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Page settings raised an exception when USE_I18N = False #8236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 22, 2025
Merged

fix: Page settings raised an exception when USE_I18N = False #8236

merged 11 commits into from
May 22, 2025

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented May 22, 2025 •
edited
Loading

Description

This ports forward @jbazik's fix in #6687 to django CMS 4+

An additional change is in plugin_pool.py which does seem not to have carried over from release/5.0.x to main.

Related resources

Checklist

  • I have opened this pull request against main
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@sourcery-ai

@django-cms django-cms deleted a comment from sourcery-ai bot May 22, 2025
@fsbraun fsbraun merged commit 68aa0b3 into main May 22, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar
0