10000 fix: Django 5.2 tried to adding object tools to the page tree throwing an error by fsbraun · Pull Request #8200 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Django 5.2 tried to adding object tools to the page tree throwing an error #8200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2025
Merged

fix: Django 5.2 tried to adding object tools to the page tree throwing an error #8200

merged 2 commits into from
Apr 20, 2025

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Apr 16, 2025 •
edited
Loading

Description

This might actually be an unintentional regression (https://code.djangoproject.com/ticket/36331)

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against main
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Bug Fixes:

  • Resolve an error when adding pages through object tools in Django 6 admin interface

@fsbraun @vinitkumar
fix: Django 6 tried to adding object tools to the page tree throwing …
2b556e4 
…an error (#8133)

* fix: Django 6 tried to add an Add page through the object tools and throws an error

* Clearer formatting

---------

Co-authored-by: Vinit Kumar <mail@vinitkumar.me>
@sourcery-ai Sourcery AI
Copy link
Contributor
sourcery-ai bot commented Apr 16, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request adds the object-tools-items block to the base.html template in the cms/page/tree directory. This change addresses an issue where Django 6 attempts to add page actions via object tools, which was causing an error. By adding this block, developers can now customize the object tools section in the page tree view.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The object-tools-items block was added to the base.html template.
  • Added the object-tools-items block to allow customization of object tools in the page tree view.
  • This resolves an error caused by Django 6 trying to add page actions to the object tools.
 cms/templates/admin/cms/page/tree/base.html
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions GitHub Actions
Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fsbraun - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It's good to see a backport of a fix, especially one related to compatibility with newer Django versions.
  • Consider adding a more detailed explanation of the issue and the fix in the commit message for better context in the future.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions GitHub Actions
Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

@fsbraun fsbraun force-pushed the chore/no-obj-tools-for-page branch from 12df0fe to 78c3b24 Compare April 16, 2025 23:00
@github-actions GitHub Actions
Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

@fsbraun fsbraun requested a review from vinitkumar April 16, 2025 23:26
@fsbraun fsbraun changed the title fix: Django 6 tried to adding object tools to the page tree throwing an error fix: Django 5.2 tried to adding object tools to the page tree throwing an error Apr 17, 2025
vinitkumar
vinitkumar approved these changes Apr 20, 2025
View reviewed changes
Copy link
Member
@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released.

@vinitkumar vinitkumar merged commit 52af3ff into release/4.1.x Apr 20, 2025
97 checks passed
@vinitkumar vinitkumar deleted the chore/no-obj-tools-for-page branch April 20, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar
0