8000 chore: Build django CMS 4.1.5 by fsbraun · Pull Request #8196 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

chore: Build django CMS 4.1.5 #8196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 4, 2025
Merged

chore: Build django CMS 4.1.5 #8196

merged 5 commits into from
Apr 4, 2025

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Apr 4, 2025 •
edited by sourcery-ai bot
Loading

Description

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against main
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Chores:

  • Update version number across various files including init.py, static CSS files, and font references

@sourcery-ai Sourcery AI
Copy link
Contributor
sourcery-ai bot commented Apr 4, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the django CMS build to version 4.1.5. It includes changes to the version number, icon font paths, and javascript bundle.

Updated class diagram for CMS version

classDiagram
    class cms {
      - __version__ : str
    }
    note for cms "Version updated from 4.1.4 to 4.1.5"
Loading

File-Level Changes

Change Details Files
Updated the version number in the core module.
  • Bumped the version from 4.1.4 to 4.1.5.
 cms/__init__.py
Updated the path for the django CMS icon font in the scss and css files.
  • Updated the font path from 4.1.4 to 4.1.5 in _iconography.scss.
  • Updated the font path from 4.1.4 to 4.1.5 in cms.admin.css.
  • Updated the font path from 4.1.4 to 4.1.5 in cms.base.css.
  • Updated the font path from 4.1.4 to 4.1.5 in cms.pagetree.css.
  • Updated the font path from 4.1.4 to 4.1.5 in cms.welcome.css.
 cms/static/cms/sass/components/_iconography.scss
cms/static/cms/css/4.1.5/cms.admin.css
cms/static/cms/css/4.1.5/cms.base.css
cms/static/cms/css/4.1.5/cms.pagetree.css
cms/static/cms/css/4.1.5/cms.welcome.css
Updated the bundle admin pagetree min js file.
  • Updated the bundle admin pagetree min js file from 4.1.4 to 4.1.5
 cms/static/cms/js/dist/4.1.5/bundle.admin.pagetree.min.js
Added a new upgrade guide for version 4.1.5.
  • Added a new file docs/upgrade/4.1.5.rst.
 docs/upgrade/4.1.5.rst
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 4, 2025

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fsbraun - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a tool like bumpversion to automate version updates across the project.
  • It would be helpful to have a dedicated upgrade guide for users migrating to this new version.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@vinitkumar vinitkumar merged commit 5dfa7fb into release/4.1.x Apr 4, 2025
96 checks passed
@github-actions github-actions bot deleted the release/build branch April 4, 2025 16:28
@kzotoff
Copy link
kzotoff commented Apr 7, 2025

page here shows latest version as 4.1.4
https://github.com/django-cms/django-cms/blob/4.1.5/CHANGELOG.rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsbraun @kzotoff @vinitkumar
0