chore: Merging back 5.0.0a1 build #8169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request merges the changes for the 5.0.0a1 build. It includes updating the version number, modifying file paths to reflect the new version, adding asynchronous event dispatching, and introducing new CSS files for styling. Updated class diagram for StructureBoardclassDiagram
class StructureBoard {
static _triggerRefreshEvents()
}
note for StructureBoard "The _triggerRefreshEvents method now dispatches events asynchronously using setTimeout."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @fsbraun - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more specific commit message than 'Merging back', as it doesn't convey the purpose of the changes.
- It would be helpful to include a brief summary of the changes included in this merge in the description.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
vinitkumar
approved these changes
Mar 2, 2025
vinitkumar
requested changes
Mar 2, 2025
docs/requirements.in
Outdated
| @@ -10,8 +10,8 @@ sphinx-autobuild | |||
| datetime | |||
| coverage | |||
| django~=4.2 | |||
| git+https://github.com/django-cms/django-cms@release/4.1.x | |||
| -e .. | |||
There was a problem hiding this comment.
It is something left from local development? Looks like it is failing the CI.
fsbraun
commented
Mar 2, 2025
vinitkumar
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
develop-4(esp. including updated changelogs and release notes)develop-4will becomemaindevelop-4will be available for some time (to be determined) from before the mergerelease/5.0.xbranch will be createdrelease/5.0.xbranch, I will bump the version inmainto5.1.0dev(so that the main branch has a higher version number then therelease/5.0.xbranchRelated resources
Checklist
develop-4Summary by Sourcery
Updates the project to version 5.0.0a1, including changes to static files, CSS, and JavaScript bundles.
Enhancements: