8000 fix: XSS vulnerability for page title by fsbraun · Pull Request #8075 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: XSS vulnerability for page title #8075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: XSS vulnerability for page title #8075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a4508a
Fix: XSS vulnerability for page title
Nov 11, 2024
f89cc87
fix linting
Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cms/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def create_page(title, template, language, menu_title=None, slug=None,
xframe_options=constants.X_FRAME_OPTIONS_INHERIT):
"""
Creates a :class:`cms.models.Page` instance and returns it. Also
creates a :class:`cms.models.Title` instance for the specified
creates a :class:`cms.models.PageContent` instance for the specified
language.
.. warning::
Expand Down
4 changes: 1 addition & 3 deletions cms/templatetags/cms_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,9 +441,7 @@ def get_value(self, context, name, page_lookup):
if page and name in self.valid_attributes:
func = getattr(page, "get_%s" % name)
ret_val = func(language=lang, fallback=True)
if name == 'page_title':
ret_val = strip_tags(ret_val)
elif not isinstance(ret_val, datetime):
if not isinstance(ret_val, datetime):
ret_val = escape(ret_val)
return ret_val
return ''
Expand Down
13 changes: 8 additions & 5 deletions cms/tests/test_templatetags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,10 @@
from django.test import RequestFactory
from django.test.utils import override_settings
from django.utils.encoding import force_str
from django.utils.html import strip_tags
from django.utils.html import escape
from django.utils.timezone import now
from django.utils.translation import override as force_language
from djangocms_text_ckeditor.cms_plugins import TextPlugin
from djangocms_text_ckeditor.models import Text
from sekizai.context import SekizaiContext

import cms
Expand Down Expand Up @@ -139,6 +138,7 @@ def test_unicode_placeholder_name_fails_fast(self):
def test_page_attribute_tag_escapes_content(self):
script = '<script>alert("XSS");</script>'
ampersand = 'Q&A page'
partial = '"><img src=x onerror=alert(1) "'

class FakePage:
def __init__(self, title):
Expand All @@ -159,11 +159,14 @@ def __init__(self, page):
template = '{% load cms_tags %}{% page_attribute page_title %}'
output_script = self.render_template_obj(template, {}, request_script)
output_ampersand = self.render_template_obj(template, {}, request_ampersand)
output_partial = self.render_template_obj(template, {}, FakeRequest(FakePage(partial)))

self.assertNotEqual(script, output_script)
self.assertEqual(ampersand, output_ampersand)
self.assertEqual(strip_tags(script), output_script)
self.assertEqual(strip_tags(ampersand), output_ampersand)
self.assertNotEqual(ampersand, output_ampersand)
self.assertNotEqual(partial, output_partial)
self.assertEqual(escape(script), output_script)
self.assertEqual(escape(ampersand), output_ampersand)
self.assertEqual(escape(partial), output_partial)

def test_json_encoder(self):
self.assertEqual(json_filter(True), 'true')
Expand Down
0