8000 fix: Remove `Page` object from admin index (introduced by #7995) by fsbraun · Pull Request #8066 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Remove Page object from admin index (introduced by #7995) #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 5, 2024
Merged

fix: Remove Page object from admin index (introduced by #7995) #8066

merged 8 commits into from
Dec 5, 2024

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Nov 5, 2024 •
edited
Loading

Description

#7995 introduced a small regression by adding the Page model to the admin index views in addition to the Page Content model.

image

This PR hides the page model irrespective of the user's add permissions.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

fsbraun
fsbraun commented Nov 6, 2024
View reviewed changes
fsbraun
fsbraun commented Nov 6, 2024
View reviewed changes
@fsbraun fsbraun requested a review from a team November 7, 2024 10:42
vinitkumar
vinitkumar approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member
@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@vinitkumar vinitkumar merged commit fe54de4 into django-cms:develop-4 Dec 5, 2024
51 checks passed
@fsbraun fsbraun deleted the fix/page-admin branch December 5, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar
0