8000 feat: Add `FrontendEditableAdminMixin` endpoint to plugins by fsbraun · Pull Request #8062 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

feat: Add FrontendEditableAdminMixin endpoint to plugins #8062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Nov 7, 2024
Merged

feat: Add FrontendEditableAdminMixin endpoint to plugins #8062

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
24d5aee
Update of `FrontendEditableAdminMixin`
Nov 4, 2024
d556adc
Add `render_inline_field`
Nov 4, 2024
ebd7bc9
Fix linting issue
Nov 4, 2024
3d7a2c7
Add FrontendInlineAdminMixin to PlaceholderFrontend
Nov 4, 2024
00aae03
Merge branch 'django-cms:develop-4' into feat/inline-editing
fsbraun Nov 4, 2024
f29fb82
Remove template tag
Nov 4, 2024
a0c6d1f
Merge branch 'feat/inline-editing' of github.com:fsbraun/django-cms i…
Nov 4, 2024
171e513
Remove left-over register command
Nov 4, 2024
9edcd4a
Refactor FrontendEditableAdminMixin
Nov 4, 2024
5fa4ae7
Improve comments
Nov 4, 2024
1a6613f
Some more refactoring
Nov 4, 2024
f886a44
Merge branch 'django-cms:develop-4' into feat/inline-editing
fsbraun Nov 5, 2024
bc744ca
Add docs
fsbraun Nov 5, 2024
c9698c8
Add test (and fix manage command)
fsbraun Nov 5, 2024
83e5b87
Add comment
fsbraun Nov 5, 2024
582856e
fix test
fsbraun Nov 5, 2024
ba47f2f
f-strings are not templates
Nov 5, 2024
16301aa
Merge branch 'develop-4' into feat/inline-editing
fsbraun Nov 5, 2024
463e043
Merge branch 'develop-4' into feat/inline-editing
fsbraun Nov 6, 2024
32e34bf
Merge branch 'develop-4' into feat/inline-editing
fsbraun Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@fsbraun
fsbraun committed Nov 5, 2024
commit 582856ee171aad8a3a8a33e3d9a655bab2f80a70
4 changes: 2 additions & 2 deletions cms/tests/test_templatetags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,9 +703,9 @@
template = """{% load cms_tags %}{% render_model plugin "body" "body" %}"""
# The template html tags will render the object editable in the frontend
expectation = (
'<template class="cms-plugin cms-plugin-start cms-plugin-djangocms_text_ckeditor-text-body-1 cms-render-model"></template>'
f'<template class="cms-plugin cms-plugin-start cms-plugin-djangocms_text_ckeditor-text-body-{{ self.plugin_pk }} cms-render-model"></template>'

Check failure on line 706 in cms/tests/test_templatetags.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (F541) 

cms/tests/test_templatetags.py:706:13: F541 f-string without any placeholders
'&lt;b&gt;Test&lt;/b&gt;'
'<template class="cms-plugin cms-plugin-end cms-plugin-djangocms_text_ckeditor-text-body-1 cms-render-model"></template>'
f'<template class="cms-plugin cms-plugin-end cms-plugin-djangocms_text_ckeditor-text-body-{{ self.plugin_pk }} cms-render-model"></template>'

Check failure on line 708 in cms/tests/test_templatetags.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (F541) 

cms/tests/test_templatetags.py:708:13: F541 f-string without any placeholders
)

endpoint = get_object_edit_url(self.page.get_content_obj("en")) # view in edit mode
Expand Down
Loading
0