10000 chore: Removed django-app-manage dependency by updating `./manage.py` by fsbraun · Pull Request #8061 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

chore: Removed django-app-manage dependency by updating ./manage.py #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 4, 2024
Merged

chore: Removed django-app-manage dependency by updating ./manage.py #8061

merged 5 commits into from
Nov 4, 2024

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Nov 4, 2024 •
edited
Loading

Description

Testing depends on less regularly maintained third-party-apps, such as django-app-manage.

This PR removes two testing requirements:

  • django-app-manage
  • django-better-test

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from vinitkumar November 4, 2024 15:38
vinitkumar
vinitkumar approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member
@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@fsbraun fsbraun merged commit e42df7e into django-cms:develop-4 Nov 4, 2024
51 checks passed
@fsbraun fsbraun deleted the chore/drop-app-manage-dependency branch November 4, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar
0