8000 fix: Fall back to class name when app name is None by halitcelik · Pull Request #8059 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Fall back to class name when app name is None #8059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 5, 2024
Merged

fix: Fall back to class name when app name is None #8059

merged 5 commits into from
Nov 5, 2024

Conversation

halitcelik
Copy link
Contributor
@halitcelik halitcelik commented Nov 2, 2024 •
edited by fsbraun
Loading

Description

Fall back to class name when the name of a CMSApp is not set.

Related resources

Fixes #8055

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@halitcelik halitcelik changed the title Fall back to class name when app name is None fix: Fall back to class name when app name is None Nov 2, 2024
@fsbraun
Copy link
Member
fsbraun commented Nov 3, 2024

@halitcelik Do you think you could add a check to cms.utils.check to inform the developer that they are missing a name in their app?

@halitcelik
Copy link
Contributor Author

@fsbraun We now have a warning in check and a test for it.

fsbraun
fsbraun approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member
@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very NICE! Thank you so much.

@fsbraun fsbraun self-assigned this Nov 5, 2024
@fsbraun fsbraun merged commit 17343b0 into django-cms:develop-4 Nov 5, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees

@fsbraun fsbraun

Labels
status: ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CMSApp without a name raises misleading error
2 participants
@halitcelik @fsbraun
0