8000 fix: Improve UX when page content is missing in selected language by jrief · Pull Request #8033 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Improve UX when page content is missing in selected language #8033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2024
Merged

fix: Improve UX when page content is missing in selected language #8033

merged 4 commits into from
Oct 16, 2024

Conversation

jrief
Copy link
Contributor
@jrief jrief commented Oct 15, 2024

Description

This just improves the readability of the Page-Tree.

Screenshot 2024-10-15 at 12 02 45

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

This just changes colors and hence can't be tested.

@fsbraun fsbraun changed the title fix #7984: Improve UX when page content is missing in selected language fix: Improve UX when page content is missing in selected language Oct 15, 2024
@fsbraun fsbraun added the needs to be backported Commits need to be backported label Oct 15, 2024
@jrief jrief requested a review from sakhawy October 15, 2024 11:45
@fsbraun
Copy link
Member
fsbraun commented Oct 16, 2024 •
edited
Loading

@jrief The slightly darker page titles of the current language actually fit better in the django CMS theme, I think. I had not noticed that they were slightly brighter than the rest of the text elements. Now it fits.

I added a fix for another tiny bug with the page tree UX I stumbled upon when testing:
image

@fsbraun fsbraun merged commit 19ef774 into django-cms:develop-4 Oct 16, 2024
46 of 51 checks passed
fsbraun added a commit that referenced this pull request Oct 16, 2024
@jrief @fsbraun
fix: Improve UX when page content is missing in selected language (#8033
9f5c58d 
)

* fix #7984: Improve UX when page content is missing in selected language

* Fix add page button for empty page tree

---------

Co-authored-by: Fabian Braun <fsbraun@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

@sakhawy sakhawy Awaiting requested review from sakhawy

Assignees
No one assigned
Labels
needs to be backported Commits need to be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrief @fsbraun
0