fix: Issue 7997 remove edit page dialog #7999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see discussion at #7997 for details
fsbraun
approved these changes
Sep 19, 2024
|
@fsbraun This is already approved. Let's merge it? |
|
@vinitkumar I'd like to add some more changes that go with this and let @jrief have a look again:
|
Makes total sense. Since I didn't had this context, I thought we missed merging it. |
…utside edit mode (e.g. for viewing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #7997, this removed menu item "Edit this Page" from the toolbar
Related resources
Checklist
develop-4This feature currently has not been unit-tested, hence removing it does not change the testing outcome.