8000 fix: Respect ContentAdminManager pattern for frontend-editable models by fsbraun · Pull Request #7998 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Respect ContentAdminManager pattern for frontend-editable models #7998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 22, 2024
Merged

fix: Respect ContentAdminManager pattern for frontend-editable models #7998

merged 9 commits into from
Sep 22, 2024

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Sep 13, 2024 •
edited
Loading

Description

Currently, objects of versioned models cannot be edited from the frontend using FrontendEditableMixin.

This PR support for the ContentAdminManager mixin introduced in django CMS 4.1.

Fixes #7996. Fixes fsbraun/djangocms-blog#5

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to re 8000 view my pull request.

@fsbraun fsbraun marked this pull request as ready for review September 13, 2024 13:05
@fsbraun fsbraun requested a review from a team September 13, 2024 13:07
@fsbraun fsbraun force-pushed the fix/frontend-editable branch from 6828688 to cd32dc7 Compare September 18, 2024 13:54
@fsbraun fsbraun merged commit a56decf into django-cms:develop-4 Sep 22, 2024
33 checks passed
@fsbraun fsbraun deleted the fix/frontend-editable branch September 22, 2024 11:16
fsbraun added a commit that referenced this pull request Sep 22, 2024
@fsbraun
fix: Respect ContentAdminManager pattern for frontend-editable models (…
e4650ec 
…#7998)

* fix: Respect ContentAdminManager pattern for frontend-editable models

* Add test

* Fix test

*
811F
 Remove unnecessary imports

* Remove breadcrumbs from plugin error form

* Fix: Also respect admin manager (cache) in toolbar

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
4.1 5.0 kind: bug needs to be backported Commits need to be backported
Projects
django CMS v4
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Frontend-editing of regular model fields fails for versioned models Exception when editing post using double click
2 participants
@fsbraun @marksweb
0