10000 Fix: Structure mode toggle button disappearing from toolbar by KCuppens · Pull Request #7970 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

Fix: Structure mode toggle button disappearing from toolbar #7970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fix: Structure mode toggle button disappearing from toolbar #7970

merged 2 commits into from
Jul 29, 2024

Conversation

KCuppens
Copy link
@KCuppens KCuppens commented Jul 27, 2024 •
edited
Loading

Description

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@joshyu
Copy link
joshyu commented Jul 29, 2024

@KCuppens,
please don't include bundled js files in the PR. we can generate the bundle JS files in the release PR of the new version.

fsbraun
fsbraun requested changes Jul 29, 2024
View reviewed changes
Copy link
Member
@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the compiled JS files from the PR as mentioned by @joshyu

@KCuppens KCuppens requested a review from fsbraun July 29, 2024 07:08
@fsbraun fsbraun merged commit 7954eff into django-cms:release/4.0.1.x Jul 29, 2024
21 checks passed
@sgordeychuk sgordeychuk mentioned this pull request Jan 9, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KCuppens @joshyu @fsbraun
0