fix: Show pages titles using fallback languages in pagetree #7955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksweb
approved these changes
Jul 17, 2024
fsbraun
added a commit
that referenced
this pull request
Jul 17, 2024
fsbraun
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In django CMS 3.x the page tree only showed page titles in the current admin language. In django CMS 4 the language of the page tree can be selected using a drop down. If there is no page content object for the page in the selected language "Empty" is shown as a page title. Fallback languages are ignored:
To improve usability and allow a user to identify pages, this PR falls back to available languages and indicates the language in brackets:
Related resources
Checklist
develop-4