10000 fix: Fail silently when rendering a placeholder on a missing toolbar object by fsbraun · Pull Request #7954 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Fail silently when rendering a placeholder on a missing toolbar object #7954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2024
Merged

fix: Fail silently when rendering a placeholder on a missing toolbar object #7954

merged 3 commits into from
Jul 17, 2024

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Jul 11, 2024 •
edited
Loading

Description

Fixes #7952

If there is no toolbar object available, trying to render a placeholder now raises the PlaceholderNotFound exception.

This leads the {% placeholder %} template tag to silently fail and return and empty string.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from marksweb July 11, 2024 11:03
@fsbraun fsbraun added the needs to be backported Commits need to be backported label Jul 11, 2024
@fsbraun fsbraun changed the title Fix: Fail silently when rendering a placeholder on a missing toolbar object fix: Fail silently when rendering a placeholder on a missing toolbar object Jul 11, 2024
@marksweb marksweb force-pushed the fix/placeholder-wo-obj branch from ddcbba0 to 55028c1 Compare July 17, 2024 09:39
marksweb
marksweb reviewed Jul 17, 2024
View reviewed changes
@fsbraun fsbraun merged commit 0f81cea into django-cms:develop-4 Jul 17, 2024
32 checks passed
@fsbraun fsbraun deleted the fix/placeholder-wo-obj branch July 17, 2024 17:14
fsbraun added a commit that referenced this pull request Jul 23, 2024
@fsbraun
fix: Fail silently when rendering a placeholder on a missing toolbar …
4501b66 
…object (#7954)

* Fix: Fail silently when rendering a placeholder on a missing toolbar object

* Fix new contributor message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees

@marksweb marksweb

Labels
needs to be backported Commits need to be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Placeholder rendering fails loudly without PageContent or Model
2 participants
@fsbraun @marksweb
0