8000 docs: Update 02-templates_placeholders.rst by rcooke · Pull Request #7935 · django-cms/django-cms · GitHub
[go: up one dir, main page]

Skip to content

docs: Update 02-templates_placeholders.rst #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

rcooke
Copy link
Contributor
@rcooke rcooke commented Jun 12, 2024

In a fresh install of 4.1.1 and the start project, I discovered the static aliases placeholder only works inside the content block. I had changed my base.html to use the 3 blocks suggested, so I had to edit that to this before the static aliases showed up:
{% block content %}
{% placeholder "feature" %}
{% placeholder "content" %}
{% placeholder "splashbox" %}


{% static_alias "footer" %}

{% endblock content %}

Description

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

In a fresh install of 4.1.1 and the start project, I discovered the static aliases placeholder only works inside the content block.  I had changed my base.html to use the 3 blocks suggested, so I had to edit that to this before the static aliases showed up:
        {% block content %}
            {% placeholder "feature" %}
            {% placeholder "content" %}
            {% placeholder "splashbox" %}
            <footer>
                {% static_alias "footer" %}
            </footer>
        {% endblock content %}
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution! 🎉

As it's your first contribution, be sure to check out the contribution docs.

We invite you to join us on our Discord Server!

Welcome aboard ⛵️!

@rcooke rcooke changed the title Update 02-templates_placeholders.rst fix: Update 02-templates_placeholders.rst Jun 12, 2024
@marksweb marksweb changed the title fix: Update 02-templates_placeholders.rst docs: Update 02-templates_placeholders.rst Jun 14, 2024
@fsbraun fsbraun merged commit 90e53c3 into django-cms:develop-4 Jun 20, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0