fix: Allow viewing page settings even if page cannot be changed #7921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrief
approved these changes
May 15, 2024
There was a problem hiding this comment.
I can confirm that this PR fixes issue django-cms/djangocms-versioning#409
Thanks for the quick response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes django-cms/djangocms-versioning#409
django CMS does not differentiate user or page-based permissions to change or view page settings.
Since django CMS versioning overwrites the
has_change_permissionmethod of thePageContentAdminclass, it needs ahas_view_permissionmethod, too. By default, they do return the same logic based on the user's ability to change this page. It is however not overwritten when a subclass adds to thehas_change_permissionlogic.Related resources
Checklist
develop-4