fix: Undo RTL bug and moved the structure board back to the right for LTR #7891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sakhawy Can you check this quickly, please? |
marksweb
approved these changes
Apr 26, 2024
jrief
approved these changes
Apr 26, 2024
|
@fsbraun Sorry and thanks for the fix! I don't know why I put |
|
@sakhawy Thanks for double-checking. I just wanted to be sure this is the right way to go. |
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression introduced with RTL support.
It also adjusts the arrows for menus and the structure board to point left instead of right.
It is raised against
release/4.1.xto be quickly included in the release process of 4.1.1. It will hitdevelop-4upon merging back the 4.1.1 release.Related resources
Checklist
develop-4