8000 fix: Redirects to newly created object by fsbraun · Pull Request #7864 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Redirects to newly created object #7864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 4, 2024
Merged

fix: Redirects to newly created object #7864

merged 10 commits into from
Apr 4, 2024

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Apr 2, 2024 •
edited
Loading

Description

This PR introduces redirection after a new page has been created from the frontend. It fixes #7706, #7804, and #7826.

Also, the method CMSTestCase.get_page_title_obj has been deprecated in favour of CMSTestCase.get_pagecontent_obj.

Tests for the fixes are added to test_page_admin.py.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from jrief April 2, 2024 15:41
@fsbraun fsbraun requested a review from a team April 2, 2024 16:07
@fsbraun fsbraun merged commit 0b43a43 into django-cms:develop-4 Apr 4, 2024
@fsbraun fsbraun deleted the fix/redirect-after-create branch April 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

@jrief jrief Awaiting requested review from jrief

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Usability flaw: Users expect to be redirected onto created page
3 participants
@fsbraun @marksweb @jrief
0