8000 ci: Added pre-commit including ruff linting & formatting by marksweb · Pull Request #7788 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

ci: Added pre-commit including ruff linting & formatting #7788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 29, 2024
Merged

ci: Added pre-commit including ruff linting & formatting #7788

merged 8 commits into from
Jan 29, 2024

Conversation

marksweb
Copy link
Member

Description

This brings pre-commit hooks into v4 as well as linting and formatting from ruff.

I've ran some basic rule fixes, mostly the ones ruff will fix itself witht he --fix flag.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

fsbraun
fsbraun approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member
@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Quite an update!

@marksweb
Copy link
Member Author

Nice! Quite an update!

Yes, well I didn't realise we didn't have pre-commit in v4 yet. So here we are. And a code formatter!

I'll likely sync this setup for v3 as well so that everything matches.

@marksweb marksweb merged commit e1ba77a into develop-4 Jan 29, 2024
@marksweb marksweb deleted the ci/pre-commit branch January 29, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marksweb @fsbraun
0