8000 fix: editing of apphooked CMS pages without apphook landing page by Chilipp · Pull Request #7766 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: editing of apphooked CMS pages without apphook landing page #7766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 18, 2024
Merged

fix: editing of apphooked CMS pages without apphook landing page #7766

merged 4 commits into from
Jan 18, 2024

Conversation

Chilipp
Copy link
Contributor
@Chilipp Chilipp commented Jan 15, 2024 •
edited
Loading

Summary

Fixes #7765

Links to related discussion

Proposed changes in this pull request

this implements a small patch and a test to make sure, that CMS pages that hold an apphook without a urlpattern at the ""-location still have the correct pagecontent object at the edit url

Documentation checklist

  • I have updated CHANGELOG.txt if appropriate
  • I have updated the release notes document if appropriate, with:
    • general notes
    • bug-fixes
    • improvements/new features
    • backwards-incompatible changes
    • required upgrade steps
    • names of contributors
  • I have updated other documentation
  • I have added my name to the AUTHORS file
  • This PR's documentation has been approved by Daniele Procida

Chilipp added a commit to Chilipp/django-cms that referenced this pull request Jan 15, 2024
@Chilipp
update changelog and authors
3821e44 
adds contribution from django-cms#7766
@fsbraun fsbraun changed the title fix editing of apphooked CMS pages without apphook landing page fix: editing of apphooked CMS pages without apphook landing page Jan 15, 2024
@Chilipp
Copy link
Contributor Author
Chilipp commented Jan 15, 2024

@fsbraun I implemented the changes that we discussed in #7765. As this is my first PR to django-cms, I am not sure, where to edit the CHANGELOG.txt. seems like there is no section for 4.1.1 yet. shall I create one?

@fsbraun
Copy link
Member
fsbraun commented Jan 15, 2024

@Chilipp No need to change the Changelog. It will be automatically generated by the release process.

@Chilipp Chilipp marked this pull request as ready for review January 15, 2024 20:42
@Chilipp
Copy link
Contributor Author
Chilipp commented Jan 17, 2024

@fsbraun this PR should work now (at least the tests pass locally)

fsbraun
fsbraun approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member
@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice! Thank you!

@fsbraun
Copy link
Member
fsbraun commented Jan 17, 2024

@Chilipp I sneaked in a little unrelated change in the docs to get this out. Hope that was ok.

@Chilipp
Copy link
Contributor Author
Chilipp commented Jan 17, 2024

Sure, it's your code 😉

fsbraun
fsbraun reviewed Jan 17, 2024
View reviewed changes
@fsbraun fsbraun merged commit cd6df84 into django-cms:develop-4 Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] toolbar.obj is not set correctly in edit view when apphook landing page is a CMS page
2 participants
@Chilipp @fsbraun
0