8000 fix: #7752 – change_form template uses the wrong id by jrief · Pull Request #7753 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: #7752 – change_form template uses the wrong id #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: #7752 – change_form template uses the wrong id #7753

merged 2 commits into from
Jan 10, 2024

Conversation

jrief
Copy link
Contributor
@jrief jrief commented Jan 10, 2024

Description

Please check #7752 for details.

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@jrief jrief changed the title Fix #7752: change_form template uses the wrong id fix: #7752 – change_form template uses the wrong id Jan 10, 2024
fsbraun
fsbraun approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member
@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change_form.js is part of Django and needs the form id to be the model name + "_form". @jrief Did you check the JS error disappears?

@jrief
Copy link
Contributor Author
jrief commented Jan 10, 2024

change_form.js is part of Django and needs the form id to be the model name + "_form". @jrief Did you check the JS error disappears?

Yes it does. Btw. the (Django) super template does it exactly that way, so it must be the "right way".

@fsbraun fsbraun merged commit df0831d into django-cms:develop-4 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrief @fsbraun
0