8000 docs: Update how-to use placeholder in custom models by fsbraun · Pull Request #7742 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

docs: Update how-to use placeholder in custom models #7742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2024
Merged

docs: Update how-to use placeholder in custom models #7742

merged 4 commits into from
Jan 10, 2024

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Jan 5, 2024

Description

This is an update for the first how-to doc: Using placeholders within your custom models. The original document I created for v4 was incomplete and needed additions.

Preview here: https://django-cms-docs.readthedocs.io/en/latest/how_to/01-placeholders.html

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun added the 4.1 label Jan 5, 2024
@fsbraun fsbraun mentioned this pull request Jan 5, 2024
Closed
2 tasks
@makjaveli
Copy link

Looks far more complete, thank you! Just a little suggestion to make the names through the document consistent. For example the placeholder name in the beginning called "my_placeholder", later on it is called "placeholder_1".

@fsbraun fsbraun requested a review from a team January 5, 2024 21:59
marksweb
marksweb reviewed Jan 10, 2024
View reviewed changes
marksweb
marksweb reviewed Jan 10, 2024
View reviewed changes
fsbraun and others added 2 commits January 10, 2024 16:22
@fsbraun @marksweb
Apply suggestions from code review
4313bbb 
Co-authored-by: Mark Walker <theshow@gmail.com>
@fsbraun
Update 01-placeholders.rst
d1a98f5
@fsbraun
Copy link
Member Author
fsbraun commented Jan 10, 2024

@marksweb Thanks for the comments! I merged the updates.

vinitkumar
vinitkumar approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member
@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@fsbraun fsbraun merged commit 885ee98 into django-cms:develop-4 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb left review comments

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fsbraun @makjaveli @vinitkumar @marksweb
0