8000 fix: Language chooser options pointing to the same language by fsbraun · Pull Request #7698 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Language chooser options pointing to the same language #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 8, 2023
Merged

fix: Language chooser options pointing to the same language #7698

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
926c870
Fix: Language chooser
fsbraun Nov 21, 2023
8cea9cf
Ensure page language uniqueness
fsbraun Nov 21, 2023
25df452
Fix linter issue
fsbraun Nov 22, 2023
c168e0f
Merge branch 'develop-4' into fix/language-chooser
fsbraun Nov 23, 2023
27576ee
Merge branch 'develop-4' into fix/language-chooser
fsbraun Nov 28, 2023
a9030b1
Merge branch 'develop-4' into fix/language-chooser
fsbraun Nov 29, 2023
3789fb3
Add edit mode and preview mode to language chooser
fsbraun Nov 22, 2023
a932635
Add option to register grouper field for frontend-editable models
fsbraun Nov 30, 2023
54529ae
Merge branch 'develop-4' into fix/language-chooser
fsbraun Nov 30, 2023
f47917e
Undo changes to cms_toolbars to avoid code redundancy
fsbraun Nov 30, 2023
be5821d
Merge branch 'fix/language-chooser' of github.com:fsbraun/django-cms …
fsbraun Nov 30, 2023
9c48d00
Simplify toolbar utils.
fsbraun Nov 30, 2023
1dc01e5
Remove not util function
fsbraun Nov 30, 2023
5efb00d
Remove unneeded imports
fsbraun Dec 1, 2023 8000
d78d33c
fix: allow for `EmptyPageContent`
fsbraun Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: allow for EmptyPageContent
  • Loading branch information
@fsbraun
fsbraun committed Dec 6, 2023
commit d78d33c9207e0f61d1aea442d535e6f02b8748e6
7 changes: 4 additions & 3 deletions cms/cms_toolbars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,9 +508,10 @@ def change_language_menu(self):
disabled = len(remove) == 1
for code, name in remove:
pagecontent = self.page.get_content_obj(code)
translation_delete_url = admin_reverse('cms_pagecontent_delete', args=(pagecontent.pk,))
url = add_url_parameters(translation_delete_url, language=code)
remove_plugins_menu.add_modal_item(name, url=url, disabled=disabled)
if pagecontent:
translation_delete_url = admin_reverse('cms_pagecontent_delete', args=(pagecontent.pk,))
url = add_url_parameters(translation_delete_url, language=code)
remove_plugins_menu.add_modal_item(name, url=url, disabled=disabled)

if copy:
copy_plugins_menu = language_menu.get_or_create_menu(
Expand Down
0