8000 fix: Replacement of SEND_BROKEN_LINK_EMAILS by BrokenLinkEmailsMiddleware by fsbraun · Pull Request #7419 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Replacement of SEND_BROKEN_LINK_EMAILS by BrokenLinkEmailsMiddleware #7419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Oct 24, 2022
Merged

fix: Replacement of SEND_BROKEN_LINK_EMAILS by BrokenLinkEmailsMiddleware #7419

merged 30 commits into from
Oct 24, 2022

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Oct 23, 2022 •
edited
Loading

Description

This fixes #5417: The Django setting SEND_BROKEN_LINK_EMAILS has been removed since Django 1.8 and replaced by a middleware.

django CMS 3.x honored both the removed settings and the middleware but only tested the case of SEND_BROKEN_LINK_EMAILS. The middleware emails were not triggered in all cases. django CMS uses the installation of BrokenLinkEmailsMiddleware only as an indicator if it should send out an email.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

fsbraun and others added 27 commits March 23, 2022 11:36
@fsbraun
Actions: run gulp build
c4fae50
@fsbraun
Add console.log
0151b22
@fsbraun
Add: github actions artifacts and see if it runs with node 10
6075489
@fsbraun
Fix: missing comma in yaml
35735a9
@fsbraun
Back to node@6
0281288
@fsbraun
Merge branch 'django-cms:develop-4' into develop-4
05a8d8e
@fsbraun
Fix: Structure board button disappearing after changing a page's content
9421e08
@fsbraun
Fix: Undo other debug changes
d7cb809
@fsbraun
Fix: Re-add cms_path to toolbar url
1a8d642
@fsbraun
Fix: Broken test
a6390d5
@fsbraun
Fix: lint errors
b405c94
@fsbraun
Fix: Improved responisveness by saving an unecessary xhr call for the…
6078f40 
… toolbar to the backend
@fsbraun
Tribute to eslint
385e38a
@fsbraun
Fix: get_toolbar xhr call needs to resolve to the cms_path not the re…
8cd900e 
…quest_pass or the toolbar will be wrongly configured
@fsbraun
Add: Test for invalid toolbar resolver path
2bc18ac
@fsbraun
Change: Buggy Helpers.updateUrlWithPath. Works fine as long as only o…
c106f59 
…ne query parameter is given. Needs to work with many
@fsbraun
Fix: toolbar py test
7da41c7
@Aiky30
Merge branch 'develop-4' into develop-4
12e09d5
@fsbraun @Aiky30
Update cms/static/cms/js/modules/cms.structureboard.js
966fe39 
Reverse formatting change

Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
@fsbraun @Aiky30
Update cms/static/cms/js/modules/cms.toolbar.js
3bc9808 
Correct formatting

Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
@fsbraun @Aiky30
Update cms/tests/test_toolbar.py
330d333 
Comment above not at end of line

Co-authored-by: Aiky30 <Aiky30@users.noreply.github.com>
@fsbraun
Update cms.base.js
0ed88e1 
Update method doc
@fsbraun
Update cms.base.js
760d4bb 
Remove trailing space
@fsbraun
Merge branch 'django-cms:develop-4' into develop-4
f906289
@fsbraun
Merge branch 'django-cms:develop-4' into develop-4
4477ed0
@fsbraun
Remove outdated setting of SEND_BROKEN_LINK_EMAILS
90dbcb9 
Fix: correct honoring of BrokenLinkEmailsMiddleware for `page_url` template tag
Fix: tests to work with BrokenLinkEmailsMiddleware
@fsbraun
add changelog entry
b78a2f4
@fsbraun fsbraun added the 4.1 label Oct 23, 2022
@marksweb marksweb merged commit 0c377c6 into django-cms:develop-4 Oct 24, 2022
@fsbraun fsbraun mentioned this pull request Oct 27, 2022
Merged
4 tasks
@fsbraun fsbraun deleted the fix/brokenLinkTests branch October 29, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsbraun @marksweb @Aiky30
0