Adding support for Django 2.2 LTS to django-cms 4.0 #6790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c476bd2 to
3d8dcd1
Compare
Aiky30
requested changes
Jan 8, 2020
* Fix typo * Fixed issue with force_color * Removed unused import * Added docs to index.rst * Fixed travis jobs * Changes after review * Fixed django version in setup * Update django-2.2.txt
FinalAngel
approved these changes
Jan 21, 2020
Aiky30
requested changes
Jan 21, 2020
There was a problem hiding this comment.
All looks ok although I'm thinking that we should also add Python 3.7 and maybe 3.8 support to the ci test list. @FinalAngel What are your thoughts on this and where is the CMS 3.7 / 3.8 aiming to support?
3 tasks
Aiky30
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherrypicks the work from develop that makes this compatible with django 2.2. The tests are currently failing because PyYaml does not support python 3.4. Furthermore python 3.4 is end of life as of March 2019 ( last year ). So I would suggest that python 3.4 is also removed from travis. Life would be simpler and everyone happier.
@FinalAngel Could you please have a look at this too?
Checklist
release/4.0.x